REP-6088 Fix display of verification summary #119
Merged
+141
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGasper
changed the title
tdq45gj
approved these changes
Jun 20, 2025
| @@ -49,6 +50,11 @@ func getMismatchesForTasks( | |||
| bson.D{ | |||
| {"task", bson.D{{"$in", taskIDs}}}, | |||
| }, | |||
| options.Find().SetSort( | |||
| bson.D{ | |||
| {"detail.id", 1}, | |||
There was a problem hiding this comment.
Is this only useful for logging? I wonder if it's going to make the query slower by sorting here.
There was a problem hiding this comment.
It should just sort the results it already has, so I don‘t expect a performance problem.
The status quo is that every presentation of the table shows different failures, which doesn’t seem very user-friendly.
- Mismatches were previously shown in an indeterminate order. Now they’re consistently sorted by the mismatched documents’ `_id`. - Documents with missing fields were being logged as entirely missing. That logic is corrected here. - The logic to create the table of missing/changed documents previously iterated through the _ids persisted in the task rather than the actual missing/changed documents. This was appropriate when that list stored mismatches but is no longer correct since the list now always stores the list of documents to check in the task. Thus, if there were only a handful of missing documents in a recheck task that contained thousands of document IDs, all of that task’s document IDs would be logged as missing. This was an oversight from PR mongodb-labs#117, which should have updated the logic to build that table as it migrated that for the mismatched-documents table. This changeset does the necessary update.
FGasper
force-pushed
the
felipe_fix_summary
branch
from
6c9de7a to
a391a17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #117 introduced some bugs in the verification summary logging. This addresses the following:
_id._ids persisted in the task rather than the actual missing/changed documents. This was appropriate when that list stored mismatches but is no longer correct since the list now always stores the list of documents to check in the task. Thus, if there were only a handful of missing documents in a recheck task that contained thousands of document IDs, all of that task’s document IDs would be logged as missing. This was an oversight from PR REP-6088 Tolerate high numbers of mismatches #117, which should have updated the logic to build that table as it migrated that for the mismatched-documents table. This changeset does the necessary update.Additional, small changes here, which I’ll merge in separate commits:
build.shnow logs the git commit & time that it’s building into the binary.compareOneDocument()method is moved to compare.go, which more sensible since that’s where it’s called.